Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to changelog guildelines from contributing docs #2415

Merged
merged 1 commit into from Sep 17, 2021

Conversation

pquentin
Copy link
Member

As noticed in #2393 where we had to ask for a changelog and it wasn't in the past tense.

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #2415 (fba1cf8) into main (7c9ca88) will decrease coverage by 0.24%.
The diff coverage is n/a.

❗ Current head fba1cf8 differs from pull request most recent head 115b2f2. Consider uploading reports for the commit 115b2f2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##              main    #2415      +/-   ##
===========================================
- Coverage   100.00%   99.75%   -0.25%     
===========================================
  Files           25       25              
  Lines         2478     2478              
===========================================
- Hits          2478     2472       -6     
- Misses           0        6       +6     
Impacted Files Coverage Δ
src/urllib3/util/wait.py 91.11% <0.00%> (-8.89%) ⬇️
src/urllib3/contrib/socks.py 97.29% <0.00%> (-2.71%) ⬇️
src/urllib3/response.py 99.75% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9ca88...115b2f2. Read the comment docs.

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sethmlarson sethmlarson merged commit da53a64 into urllib3:main Sep 17, 2021
@pquentin pquentin deleted the link-to-changelog-guidelines branch September 24, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants