New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make backoff_max configurable with default of 120 #2393
Closed
barrett-schonefeld
wants to merge
2
commits into
urllib3:main
from
barrett-schonefeld:configurable-backoff-max
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
Replaces ``Retry.BACK0FF_MAX`` with ``Retry.DEFAULT_BACKOFF_MAX``. | ||
|
||
Adds a configurable ``backoff_max`` parameter to the ``Retry`` class. | ||
If a custom ``backoff_max`` is provided to the ``Retry`` class, it | ||
will replace the ``Retry.DEFAULT_BACKOFF_MAX``. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes sense, however I think we'd need a deprecation cycle in v1.26.x to remove
BACKOFF_MAX
safely in v2.0. Perhaps we can do that since it's likely not used often.In 1.26.x I'm thinking we can go the route of other deprecated Retry classvars: #2000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, great!
To be sure I understand the process, we need a PR to deprecate
BACKOFF_MAX
. The deprecation change will be included inv1.26.x
.Then this PR (including
DEFAULT_BACKOFF_MAX
) will be introduced in2.0.0
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You understand perfectly, once that PR exists and is merged we can merge this PR.