Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3.10 tests #2201

Merged
merged 2 commits into from Apr 20, 2021
Merged

Fix Python 3.10 tests #2201

merged 2 commits into from Apr 20, 2021

Conversation

pquentin
Copy link
Member

There was a change in CPython that broke pytest. pytest-dev/pytest#8540 fixed it, which is why I bumped it but pytest was not relased, so that did not help. But it does not hurt either, so I left the version bumps.

The issue appeared since GitHub Actions released a "beta 1" CPython 3.10, which is weird since the actual beta 1 is not out yet, but this is what 3.10-dev now refers to. See pytest-dev/pytest#8540 (comment).

So the fix is to pin to alpha 7, and when pytest gets relased we'll unpin Python 3.10 and bump pytest.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #2201 (fc2244f) into main (287052a) will not change coverage.
The diff coverage is n/a.

❗ Current head fc2244f differs from pull request most recent head 6e00a5b. Consider uploading reports for the commit 6e00a5b to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2201   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         2219      2219           
=========================================
  Hits          2219      2219           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 287052a...6e00a5b. Read the comment docs.

@sethmlarson sethmlarson merged commit 51b3bb5 into urllib3:main Apr 20, 2021
@pquentin pquentin deleted the bump-dependencies branch September 24, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants