Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.26] Don't compare bytes and str in putheader() #2142

Merged
merged 3 commits into from Jan 26, 2021
Merged

Conversation

sethmlarson
Copy link
Member

Backport of #2141

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #2142 (3b106a8) into 1.26.x (b89158f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           1.26.x    #2142   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          25       25           
  Lines        2303     2303           
=======================================
  Hits         2301     2301           
  Misses          2        2           
Impacted Files Coverage Δ
src/urllib3/connection.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89158f...3b106a8. Read the comment docs.

@sethmlarson
Copy link
Member Author

Looks like macOS 2.7 is failing (I believe this is a failure we've seen before) and PyPy on Travis is failing with cryptography-related errors.

@pquentin
Copy link
Member

We want to backport https://github.com/urllib3/urllib3/pull/2035/files for the source_address issue. Never seen AttributeError: '_cffi_backend.CData' object is not a context manager (no __enter__/__exit__ method), though.

Both are unrelated to the PR

@sethmlarson
Copy link
Member Author

Going to merge and release since all the failures are unrelated. CI will have to be fixed up separately.

@sethmlarson sethmlarson merged commit 3179dfd into 1.26.x Jan 26, 2021
@sethmlarson sethmlarson deleted the backport-pr-2141 branch January 26, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants