Remove Python 2 related code from src/urllib3/connectionpool.py #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hramezani
force-pushed
the
drop_python2_connectionpool
branch
from
359c56c
to
1ce2510
Compare
Codecov Report
@@ Coverage Diff @@
## master #2066 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 2233 2228 -5
=========================================
- Hits 2233 2228 -5
Continue to review full report at Codecov.
|
sethmlarson
reviewed
Nov 16, 2020
| @@ -414,18 +397,7 @@ def _make_request( | |||
|
|
|||
| # Receive the response from the server | |||
| try: | |||
| try: | |||
There was a problem hiding this comment.
Woo, this is super great and I've been waiting to remove this since day 1 🎉
sethmlarson
reviewed
Nov 16, 2020
|
Tests passed but we hit nedbat/coveragepy#1010 again on PyPy. Closing/reopening |
hramezani
force-pushed
the
drop_python2_connectionpool
branch
from
1ce2510
to
a7c768b
Compare
sethmlarson
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up of #2044