Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PyPy to test Python 3.6 #2050

Merged
merged 2 commits into from Nov 12, 2020
Merged

Conversation

pquentin
Copy link
Member

Recreated #2035 to get the correct GitHub checks.

This works around the hanging test that puzzled me in #2034, unblocks #2044, and paves the way for GitHub Actions (#2033), where the same test was an issue too for a slighly different reason.

I have upgraded to Ubuntu 20.04 since @sethmlarson fixed the TLS v1/1.1 issue.

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #2050 (b3588cb) into master (7675532) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2050   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         2297      2296    -1     
=========================================
- Hits          2297      2296    -1     
Impacted Files Coverage Δ
src/urllib3/util/ssl_.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7675532...b3588cb. Read the comment docs.

@pquentin
Copy link
Member Author

We seem to hit nedbat/coveragepy#1010. Closing/reopening

@pquentin pquentin closed this Nov 12, 2020
@pquentin pquentin reopened this Nov 12, 2020
@pquentin
Copy link
Member Author

The only error left is macOS 2.7 which already fails on master. I'd suggest merging this, improving the behavior of our SOCKS code can always be done later on.

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Quentin!

@sethmlarson sethmlarson merged commit deb21b6 into urllib3:master Nov 12, 2020
@pquentin pquentin deleted the pypy-3.6 branch September 24, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants