Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.25.x] Don't set keylog_filename for empty values #2023

Merged

Conversation

sethmlarson
Copy link
Member

Backport of #2016

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #2023 into 1.25-series will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           1.25-series     #2023   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files               23        23           
  Lines             2009      2011    +2     
=============================================
+ Hits              2009      2011    +2     
Impacted Files Coverage Δ
src/urllib3/util/ssl_.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c54745...e6d0eaf. Read the comment docs.

@sethmlarson sethmlarson merged commit 747e9aa into urllib3:1.25-series Oct 9, 2020
@sethmlarson sethmlarson deleted the backport-sslkeylogfile branch October 9, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant