New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminate connection when custom verification fails (SecureTransport) #1977
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
362b6ba
Tests: add custom ssl verification failure test
hodbn d2eecd4
Refactor: SecureTransport trust evaluation
hodbn eb9f281
BugFix: alert and immediately close untrusted CAs with SecureTransport
hodbn 13fb905
Tests: connect to the right host in test_assert_invalid_fingerprint
hodbn 6d88c88
Tests: assert on error messages in test_assert_invalid_fingerprint
hodbn 3f1cfef
SecureTransport: ignore macOS OSError(57) on a shutting down socket
hodbn c42d429
SecureTransport: move tls alert builder to low_level.py
hodbn 00136cf
SecureTransport: add docs to SO_LINGER
hodbn 7ce1963
Tests: remove unnecessary calls from test_assert_invalid_fingerprint
hodbn e7f58d1
SecureTransport: close the invalid ssl socket correctly
hodbn 8f9b974
Tests: test that an unknown ca alert was sent
hodbn File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some useful documentation or even StackOverflow link for this?