Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate TLS-in-TLS support into urllib3 #1923

Merged
merged 13 commits into from Sep 28, 2020

Commits on Aug 19, 2020

  1. Integrate SSLTransport into urllib3.

    For connections that will attempt to use an HTTPS proxy with an HTTPS
    destination, we'll use the TLS in TLS support provided by SSL Transport.
    
    HTTPS proxy and HTTP destinations will continue using a single TLS
    session as expected.
    
    We'll still support the use of forwarding for HTTPS destinations with
    HTTPS proxies as long as the "use_forwarding_for_https" parameter is
    provided.
    
    Signed-off-by: Jorge Lopez Silva <jalopezsilva@gmail.com>
    jalopezsilva committed Aug 19, 2020
    Copy the full SHA
    4ff1d93 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    8eac255 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Address review comments - Round urllib3#1.

    - Make the toggle for absolute URI forwarding public and adjust
      documentation.
    - Adjust documentation in util/proxy.py for connection_requires_http_tunnel.
    - Only set the proxy_pass if the pass was provided.
    - Adjust unsupported ssl.SSLContext check.
    - Remove 'server_hostname' parameter on platforms without SNI support.
    - Better handling and passing of destination scheme between
      connectionpool and connection.
    jalopezsilva committed Sep 8, 2020
    Copy the full SHA
    4895dec View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    057cea2 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary parameter from urllopen.

    - Mistake in previous commit.
    jalopezsilva committed Sep 8, 2020
    Copy the full SHA
    e78ee2f View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2020

  1. Copy the full SHA
    05c94b9 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2020

  1. Address review comments - Round urllib3#2

    - Improve documentation syntax.
    - Use Python 2 instead of py2.
    - Remove support for configuring through environment variables.
    - Nit and suggestions on util.ssl_.py
    - Improvements on validation and error messages for not supported
      SSLContext.
    jalopezsilva committed Sep 13, 2020
    Copy the full SHA
    09e9e47 View commit details
    Browse the repository at this point in the history
  2. Address review comments - Round urllib3#3.

    - Move to staticmethod instead of classmethod, also make it private.
    - Error out if SSLTransport isn't available and we need to do
      TLS-in-TLS.
    - Avoid modifying the signature of prepare_proxy.
    jalopezsilva committed Sep 13, 2020
    Copy the full SHA
    fd2605d View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Remove out of date comment.

    - We no longer need to pass the upstream destination.
    jalopezsilva committed Sep 21, 2020
    Copy the full SHA
    7585d8d View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    1fec027 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2020

  1. Address review comments - Round urllib3#4.

    - Rename 'generate_proxy_ssl_context' to 'create_proxy_ssl_context'
    - Remove unnecessary method to set the 'tls_in_tls_required' attribute.
    - Improve handling of default ssl_context.
    - Improve warning message for Python2.
    - Fix missing assert on secure transport.
    - Other test renames.
    jalopezsilva committed Sep 27, 2020
    Copy the full SHA
    3fcd547 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    fa7c751 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. Rename missing test.

    jalopezsilva committed Sep 28, 2020
    Copy the full SHA
    cabdf90 View commit details
    Browse the repository at this point in the history