Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.25.7 #1745

Merged
merged 2 commits into from Nov 11, 2019
Merged

Release 1.25.7 #1745

merged 2 commits into from Nov 11, 2019

Conversation

sethmlarson
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #1745 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1745   +/-   ##
======================================
  Coverage    99.7%   99.7%           
======================================
  Files          22      22           
  Lines        2003    2003           
======================================
  Hits         1997    1997           
  Misses          6       6
Impacted Files Coverage Δ
src/urllib3/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 109c70f...69390cb. Read the comment docs.

@pquentin
Copy link
Member

Yay, a release!

I think there are a few missing changelog entries:

Not sure about the wording, but they are user-visible changes. Well, the SecureTransport change is not really visible, but we advertised TLS 1.3 support for all TLS backends in the past, and it's no longer there.

@sethmlarson
Copy link
Member Author

You're right, I'll add all those to the changelog! Thanks :)

@sethmlarson
Copy link
Member Author

@pquentin When you get a second to gloss over my addition that'd be great.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Should you be the one using the merge button here?

@sethmlarson sethmlarson merged commit 37ba61a into urllib3:master Nov 11, 2019
@sethmlarson sethmlarson deleted the release-1.25.7 branch November 11, 2019 15:05
@sethmlarson
Copy link
Member Author

🎉 Will be uploading the release shortly.

Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants