Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get coverage back to 100% #1726

Merged
merged 3 commits into from Nov 22, 2019
Merged

Get coverage back to 100% #1726

merged 3 commits into from Nov 22, 2019

Commits on Nov 10, 2019

  1. Cover AppEngine methods about environ 

    They always return False in our case, but at least we test that they
exist and don't crash.
    @pquentin
    pquentin committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    c109b24 View commit details
    Browse the repository at this point in the history

  2. Assume that _encode_target urls start with slash 

    Indeed, the only _encode_target only calls it if the url starts with a
slash.
    @pquentin
    pquentin committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    14db804 View commit details
    Browse the repository at this point in the history

  3. Remove unused HTTPSConnection.connect() 

    Unverified connections also go through VerifiedHTTPSConnection.
    @pquentin
    pquentin committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    011d857 View commit details
    Browse the repository at this point in the history