Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip broken pipe errors #1524

Merged
merged 32 commits into from Sep 11, 2020
Merged

Skip broken pipe errors #1524

merged 32 commits into from Sep 11, 2020

Commits on May 24, 2019

  1. Skipping the broken pipe errors. 

    In the case the server legitimally close a connection but we are still
sending data (e.g. sending a POST request), the old code prevents the
response to be retrieved.

With this change, we avoid a broken pipe in the request write process,
to end the read process.
    @robermorales
    robermorales committed May 24, 2019
    Copy the full SHA
    7ffb24e View commit details
    Browse the repository at this point in the history

  2. Included request_chunked() in the control. 

    Added a comment with the rationale.
    @robermorales
    robermorales committed May 24, 2019
    Copy the full SHA
    d4416f0 View commit details
    Browse the repository at this point in the history

  3. Added tests

    @robermorales
    robermorales committed May 24, 2019
    Copy the full SHA
    3a285b9 View commit details
    Browse the repository at this point in the history

  4. Added tests for the request_chunked() case

    @robermorales
    robermorales committed May 24, 2019
    Copy the full SHA
    5e68837 View commit details
    Browse the repository at this point in the history

  5. ignoring chunked test for Google App Engine

    @robermorales
    robermorales committed May 24, 2019
    Copy the full SHA
    9a484d3 View commit details
    Browse the repository at this point in the history

  6. Skip on is_appengine()

    @sethmlarson @robermorales
    sethmlarson authored and robermorales committed May 24, 2019
    Copy the full SHA
    3e18f38 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2020

  1. merge new master

    @hodbn
    hodbn committed Apr 22, 2020
    Copy the full SHA
    ffeeb0e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into broken-pipe-detection

    @hodbn
    hodbn committed Apr 22, 2020
    Copy the full SHA
    70b1f0c View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. rewrite broken pipe tests

    @hodbn
    hodbn committed Apr 23, 2020
    Copy the full SHA
    5750179 View commit details
    Browse the repository at this point in the history

  2. account for EPROTOTYPE on osx

    @hodbn
    hodbn committed Apr 23, 2020
    Copy the full SHA
    567a8f4 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Fix test_broken_pipe_ignore ignore on macOS 

    When the server closed the socket but the client still tries to read the
response, macOS can fail with EPROTOTYPE instead of simply EPIPE or
ESHUTDOWN, so BrokenPipeError isn't enough.

I also had to fix the test, otherwise the request would fail because it
didn't read the whole response (which is still a healthy thing to do).
    @pquentin @hodbn
    pquentin authored and hodbn committed Apr 28, 2020
    Copy the full SHA
    ec5ba40 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Change TARPIT_HOST to detect isolated network (urllib3#1862)

    @hodbn @pquentin
    hodbn authored and pquentin committed Jun 30, 2020
    Copy the full SHA
    2a12bcf View commit details
    Browse the repository at this point in the history

  2. Add 'other errors' counter to Retry (urllib3#1824)

    @hodbn @pquentin
    hodbn authored and pquentin committed Jun 30, 2020
    Copy the full SHA
    0f3afa9 View commit details
    Browse the repository at this point in the history

  3. Don't insert 'None' into ConnectionPool if it was empty

    @hodbn @pquentin
    hodbn authored and pquentin committed Jun 30, 2020
    Copy the full SHA
    3ac99e2 View commit details
    Browse the repository at this point in the history

  4. Fix linting for flake8 v3.8

    @pquentin
    pquentin committed Jun 30, 2020
    Copy the full SHA
    2f92f16 View commit details
    Browse the repository at this point in the history

  5. Use nox version that works with Python 3.5.2 

    This is the default `python3` shipped by Travis.
    @pquentin
    pquentin committed Jun 30, 2020
    Copy the full SHA
    fe8f85f View commit details
    Browse the repository at this point in the history

  6. Add InvalidChunkLength error

    @hodbn @pquentin
    hodbn authored and pquentin committed Jun 30, 2020
    Copy the full SHA
    d3901a8 View commit details
    Browse the repository at this point in the history

  7. Test buggy incomplete read

    @hodbn @pquentin
    hodbn authored and pquentin committed Jun 30, 2020
    Copy the full SHA
    082b78d View commit details
    Browse the repository at this point in the history

  8. Fix coverage, InvalidChunkLength is chunked and has no expected length

    @hodbn @pquentin
    hodbn authored and pquentin committed Jun 30, 2020
    Copy the full SHA
    2ee6eac View commit details
    Browse the repository at this point in the history

  9. Update docs for an old Python version test

    @hodbn @pquentin
    hodbn authored and pquentin committed Jun 30, 2020
    Copy the full SHA
    b0a8d79 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary httplib export

    @hodbn @pquentin
    hodbn authored and pquentin committed Jun 30, 2020
    Copy the full SHA
    e83cb29 View commit details
    Browse the repository at this point in the history

  11. Feature/support env var sslkeylogfile (urllib3#1867)

    @bastiaanb @pquentin
    bastiaanb authored and pquentin committed Jun 30, 2020
    Copy the full SHA
    a024db5 View commit details
    Browse the repository at this point in the history

  12. Add documentation for using Nox more efficiently (urllib3#1887)

    @PleasantMachine9 @pquentin
    PleasantMachine9 authored and pquentin committed Jun 30, 2020
    Copy the full SHA
    c9c57b4 View commit details
    Browse the repository at this point in the history

  13. Fix testing of SSLKEYLOGFILE on AppVeyor

    @hodbn @pquentin
    hodbn authored and pquentin committed Jun 30, 2020
    Copy the full SHA
    75aca6a View commit details
    Browse the repository at this point in the history

  14. Raise a meaningful error for an unknown scheme (urllib3#1872)

    @hodbn @pquentin
    hodbn authored and pquentin committed Jun 30, 2020
    Copy the full SHA
    aa06d7a View commit details
    Browse the repository at this point in the history

  15. Add default user agent header (urllib3#1750) 

    Co-authored-by: hodbn <hodbn@users.noreply.github.com>
    @hodbn @pquentin
    2 people authored and pquentin committed Jun 30, 2020
    Copy the full SHA
    2275717 View commit details
    Browse the repository at this point in the history

  16. Merge remote-tracking branch 'urllib3/master' into robermorales-broke… 

    …n-pipe-detection
    @pquentin
    pquentin committed Jun 30, 2020
    Copy the full SHA
    ccd3288 View commit details
    Browse the repository at this point in the history

  17. Clarify that behavior is identical with Python 2

    @pquentin
    pquentin committed Jun 30, 2020
    Copy the full SHA
    4a7040c View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. Skip BrokenPipeError test on Windows

    @sethmlarson
    sethmlarson committed Aug 28, 2020
    Copy the full SHA
    c6ae228 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Merge branch 'master' into broken-pipe-detection

    @sethmlarson
    sethmlarson committed Sep 4, 2020
    Copy the full SHA
    7450d79 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. Merge branch 'master' of ssh://github.com/urllib3/urllib3 into broken… 

    …-pipe-detection
    @sethmlarson
    sethmlarson committed Sep 11, 2020
    Copy the full SHA
    d4d97de View commit details
    Browse the repository at this point in the history

  2. De-duplicate notWindows decorator

    @sethmlarson
    sethmlarson committed Sep 11, 2020
    Copy the full SHA
    2335967 View commit details
    Browse the repository at this point in the history