Update CHANGES and CONTRIBUTORS #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1431 +/- ##
======================================
Coverage 100% 100%
======================================
Files 21 21
Lines 1790 1790
======================================
Hits 1790 1790Continue to review full report at Codecov.
|
sethmlarson
requested changes
Aug 24, 2018
CONTRIBUTORS.txt
Outdated
| * Fix leaking exceptions when system calls are interrupted with zero timeout | ||
|
|
||
| * [Hugo van Kemenade] <https://github.com/hugovk> |
There was a problem hiding this comment.
Remove the square braces around your name
| @@ -11,6 +11,8 @@ dev (master) | |||
| * Add a server_hostname parameter to HTTPSConnection which allows for | |||
There was a problem hiding this comment.
Could you move the "... " changelist entry to the bottom of the list? I don't know how it crept up there! :)
CHANGES.rst
Outdated
| @@ -11,6 +11,8 @@ dev (master) | |||
| * Add a server_hostname parameter to HTTPSConnection which allows for | |||
| overriding the SNI hostname sent in the handshake. (Pull #1397) | |||
|
|
|||
| * Drop support for EOL Python 2.6 (Pull #1429) | |||
There was a problem hiding this comment.
Thanks, I've updated these three things.
sethmlarson
approved these changes
Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PR #1429.
Also update some HTTP links to HTTPS.