Add SKIP_HEADER for skipping automatically added headers #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
commented
Oct 5, 2020
hodbn
reviewed
Oct 6, 2020
Co-authored-by: hodbn <hodbn@users.noreply.github.com>
|
Thanks @hodbn for the test case, I added you as a coauthor to the patch you sent me :) |
sethmlarson
force-pushed
the
skip-user-agent
branch
from
6bc1f22
to
5ac4e44
Compare
sethmlarson
force-pushed
the
skip-user-agent
branch
from
5ac4e44
to
a66c224
Compare
Codecov Report
@@ Coverage Diff @@
## master #2018 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 2290 2298 +8
=========================================
+ Hits 2290 2298 +8
Continue to review full report at Codecov.
|
hodbn
requested changes
Oct 18, 2020
sethmlarson
changed the title
|
@hodbn Thanks for the review, good catch on the copy issue. |
hodbn
approved these changes
Oct 19, 2020
This was referenced Mar 12, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2014, Closes #2021
Changed the sentinel from
SUPPRESS_USER_AGENTtoSKIP_HEADERfor skipping 3 of the automatically added headersAccept-Encoding,Host, andUser-Agent.cc @nateprewitt could you test this to ensure it works as you're expecting?