Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittests are failing with urllib3>1.26 #1272

Closed
matusvalo opened this issue Nov 16, 2020 · 1 comment · Fixed by #1273
Closed

Unittests are failing with urllib3>1.26 #1272

matusvalo opened this issue Nov 16, 2020 · 1 comment · Fixed by #1273

Comments

@matusvalo
Copy link
Member

Unittests are failing with error:

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <botocore.awsrequest.AWSHTTPConnection object at 0x7f9c856d7278>

header = 'Host', values = (b'169.254.169.254',)

    def putheader(self, header, *values):

        """"""

>       if SKIP_HEADER not in values:

E       BytesWarning: Comparison between bytes and string

.tox/3.7-linux-unit/lib/python3.7/site-packages/urllib3/connection.py:218: BytesWarning

It seems that the issue was introduced by:
urllib3/urllib3#2018

@thedrow
Copy link
Member

thedrow commented Nov 16, 2020

We probably need an issue to support the newer versions...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants