New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Engine Error with HTTPS #1503
Comments
speedplane
added a commit
to speedplane/urllib3
that referenced
this issue
Dec 19, 2018
…on. Make sure we check for that. urllib3#1503. Not this reverts part of the change in urllib3#1430.
speedplane
added a commit
to speedplane/urllib3
that referenced
this issue
Dec 19, 2018
…on. Make sure we check for that. urllib3#1503. Not this reverts part of the change in urllib3#1430.
See PR #1504 for the related PR. |
jpevarnek
added a commit
to jpevarnek/urllib3
that referenced
this issue
Jan 24, 2019
urllib3 removed support for Python versions before 2.7 in a previous pull request, unfortunately, this broke environments that use a different implementation of httplib than the one in Python's standard library as well. This includes Google App Engine's urlfetch-based implementation (https://github.com/GoogleCloudPlatform/python-compat-runtime/blob/master/appengine-compat/exported_appengine_sdk/google/appengine/dist27/gae_override/httplib.py#L362) This pull request is nearly identical to urllib3#1504 which was closed due to its author not responding to comments. Fixes urllib3#1503
jpevarnek
added a commit
to jpevarnek/urllib3
that referenced
this issue
Jan 24, 2019
urllib3 removed support for Python versions before 2.7 in a previous pull request, unfortunately, this broke environments that use a different implementation of httplib than the one in Python's standard library as well. This includes Google App Engine's urlfetch-based implementation (https://github.com/GoogleCloudPlatform/python-compat-runtime/blob/master/appengine-compat/exported_appengine_sdk/google/appengine/dist27/gae_override/httplib.py#L362) This pull request is nearly identical to urllib3#1504 which was closed due to its author not responding to comments. Fixes urllib3#1503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I believe the change in PR #1430 broke urllib3 on Google App Engine, which doesn't have
_tunnel_host
in its implementation of httplib. Not sure why this wasn't picked up by tests, but the fix is easy, simply addingif getattr(self, '_tunnel_host', None)
part should go back in.Below is a stacktrace of the error. Note that this is pure urllib3, no requests are being used.
The text was updated successfully, but these errors were encountered: