Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme for the v2 merge #924

Merged
merged 2 commits into from Nov 13, 2019
Merged

Update readme for the v2 merge #924

merged 2 commits into from Nov 13, 2019

Conversation

coilysiren
Copy link
Member

(title)

@coilysiren coilysiren requested a review from a team as a code owner November 9, 2019 06:29
@coilysiren coilysiren self-assigned this Nov 9, 2019
@codecov
Copy link

codecov bot commented Nov 9, 2019

Codecov Report

Merging #924 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #924   +/-   ##
=======================================
  Coverage   72.89%   72.89%           
=======================================
  Files          32       32           
  Lines        2439     2439           
=======================================
  Hits         1778     1778           
  Misses        550      550           
  Partials      111      111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0587424...e2bb4bb. Read the comment docs.

Copy link
Member

@asahasrabuddhe asahasrabuddhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too

@@ -18,7 +18,7 @@ applications in an expressive way.
Usage documentation exists for each major version

- `v1` - [./docs/v1/manual.md](./docs/v1/manual.md)
- `v2` - 🚧 documentation for `v2` is WIP 🚧
- `v2` - [./docs/v2/manual.md](./docs/v2/manual.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a note that this belongs to the master branch as well? (See #925)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a note that this belongs to the master branch as well? (See #925)

Since we require 2 approving reviews, I'll do this in a followup PR

@coilysiren coilysiren merged commit f6f1ac6 into master Nov 13, 2019
@coilysiren coilysiren deleted the lynncyrin-patch-1 branch November 21, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants