Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v2 branch with #912 #913

Merged
merged 6 commits into from Oct 21, 2019
Merged

Conversation

rliebz
Copy link
Member

@rliebz rliebz commented Oct 21, 2019

This can be merged as soon as #912 is merged in to keep the v2-master-merge branch up to date with master.

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #913 into v2-master-merge will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           v2-master-merge     #913      +/-   ##
===================================================
+ Coverage             72.8%   72.89%   +0.09%     
===================================================
  Files                   32       32              
  Lines                 2438     2439       +1     
===================================================
+ Hits                  1775     1778       +3     
+ Misses                 551      550       -1     
+ Partials               112      111       -1
Impacted Files Coverage Δ
help.go 80.11% <100%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd9978...b5bef8e. Read the comment docs.

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again 👍

@coilysiren coilysiren merged commit e72f87a into urfave:v2-master-merge Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants