Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for getting alternate name flag values from yaml/toml/json #791

Closed
wants to merge 0 commits into from

Conversation

pysqz
Copy link

@pysqz pysqz commented Jan 8, 2019

fix issue #711. please check~

@mdbraber
Copy link

mdbraber commented Jan 14, 2019

Thanks for creating this patch, hope this gets merged soon! For those who want to use this now:

go get gopkg.in/urfave/cli.1
cd $GOPATH/src/gopkg.in/urfave/cli.1
git remote add upstream https://github.com/pysqz/cli-1.git
git fetch upstream
git checkout remotes/upstream/master

@mdbraber
Copy link

It seems that this fix doesn't work yet with NewStringSliceFlag. Any ideas what could be changed?

@pysqz
Copy link
Author

pysqz commented Jan 15, 2019

Repush a patch #792. It can fix this bug with StringSliceFlag and IntSliceFlag. Please review again~ @mdbraber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants