Add PathFlag #670
Add PathFlag #670
Conversation
|
This need additional work that is discussed in #666. |
| } | ||
|
|
||
| // ApplyWithError populates the flag given the flag set and environment | ||
| func (f *PathFlag) ApplyWithError(set *flag.FlagSet) error { |
There was a problem hiding this comment.
I take it we don't need to resolve the path in here since it'll be relative to the working directory.
altsrc/flag.go
Outdated
| @@ -231,3 +255,19 @@ func isEnvVarSet(envVars []string) bool { | |||
| func float64ToString(f float64) string { | |||
| return fmt.Sprintf("%v", f) | |||
| } | |||
|
|
|||
| func stringToPath(context *cli.Context, path string) (string, error) { | |||
| inputSourcePath := context.String("load") | |||
There was a problem hiding this comment.
I see, yes, it'll be difficult to access the path of the loaded file from here.
One approach could be to add another method to InputSourceContext that returns the filepath of the source; this value would then be passed in by the YAML and TOML loaders to the constructed MapInputSource.
There was a problem hiding this comment.
Yeah, I was thinking in the same direction. I'll do that. Cheers!
|
FYI I'll rebase and squash the commits before merging. |
altsrc/input_source_context.go
Outdated
| @@ -9,6 +9,8 @@ import ( | |||
| // InputSourceContext is an interface used to allow | |||
| // other input sources to be implemented as needed. | |||
| type InputSourceContext interface { | |||
| Source() string | |||
There was a problem hiding this comment.
Can we add a comment here to make it more clear for implementers what this should return?
|
This looks great @VMitov ! Thank you for adding the comprehensive tests. I just left one note about commenting the interface, but I think this is good to go after that. |
|
👍 looks great! Let me know if you still want to squash. |
|
Rebased. |
No description provided.