Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve readme a bit more #1906

Merged
merged 2 commits into from May 3, 2024
Merged

Conversation

bartekpacia
Copy link
Contributor

What type of PR is this?

  • documentation

What this PR does / why we need it:

This small PR improves README a bit more (and answers this question).

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Testing

None

Release Notes

None

@bartekpacia bartekpacia requested a review from a team as a code owner May 2, 2024 20:26
Copy link
Contributor

@abitrolly abitrolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today is a grumpy day. :D

README.md Outdated
Comment on lines 36 to 38
If you found a bug or have a feature request, [create a new issue].

See [`LICENSE`](./LICENSE).
Please keep in mind that this project is run entirely by unpaid volunteers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a speculation. Maybe somebody is paid. I don't know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, you're reight. I wish I was.

I removed "entirely", it sounded too strong. Or would you prefer to remove this line completely?


## License
If you found a bug or have a feature request, [create a new issue].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less is more. Too much water on obvious things makes people skip what is really important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less is more.

Agreed.

But I think this makes sense – for questions, go to discussion. For problems/requests, go to issues.

And label kind/question would be a no-op.


See [`LICENSE`](./LICENSE).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License in important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

facts

re-added

Copy link
Contributor

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@bartekpacia bartekpacia merged commit 84cb04e into urfave:main May 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants