Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Show non categorized flags with categorized on help #1854

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Backport Show non categorized flags with categorized on help #1854

merged 1 commit into from
Dec 27, 2023

Conversation

jetexe
Copy link
Contributor

@jetexe jetexe commented Dec 27, 2023

What type of PR is this?

  • bug
  • feature

What this PR does / why we need it:

Reverting the removal of visible flags from help if their sibling flags have categories defined.

Example:

App:
    Flags:
        Flag1: // non categorized
        Flag2: Category1
        
Help Before PR:
    Options:
      Category1
        Flag2
        
Help After:
    Options:
        Flag1
      
      Category1
        Flag2

Which issue(s) this PR fixes:

fixes #1672 for version 3

Special notes for your reviewer:

This is a backport (or forwardport in our case) of #1673

Testing

  • Unit tests added
  • Example application tryed

Release Notes

Reverted removal of non categorized flags alongside categorized flags

Copy link
Contributor

@tarampampam tarampampam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@dearchap dearchap merged commit 7a9aea9 into urfave:main Dec 27, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix categorized flags alongside non categorized
3 participants