Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:(issue_1842) Make value source chain more user friendly #1849

Merged
merged 5 commits into from
Dec 25, 2023

Conversation

dearchap
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • cleanup
  • feature

What this PR does / why we need it:

(REQUIRED)

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #1842

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)

A NewValueSourceChain function has been added to make it easier for users to create a value source chain. Value source chains can be now be appended together. 

Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dearchap dearchap merged commit 82b1afc into urfave:main Dec 25, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] how to chain multible Sources?
2 participants