Move test helpers from docs_test.go to helpers_test.go #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the documentation for precedence
Move test helpers (which are also used in fish_test.go) out of docs_test.go and into the existing helpers_test.go. This will allow to use build tags to exclude features exposed by docs.go.
|
Wong branch. |
|
Build tag is already available in #1375. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Refactor unit tests to move test helpers (
testApp,expectFileContent) fromdocs_test.gointo the existinghelpers_test.go. Those helpers are used by bothdocs_test.goandfish_test.go.Why? I will soon propose to add build tags in docs.go to allow to skip the features it provides, and those dependencies get in the way.
Release Notes
NONE