Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 - Fix incorrectTypeForFlagError for pointers #1707

Closed
wants to merge 1 commit into from

Conversation

danhunsaker
Copy link

What type of PR is this?

  • bug

What this PR does / why we need it:

When configs parsed into MapInputSource are looked up, they report type mismatch errors, as expected. However, if the type is mismatched because it somehow ended up becoming a pointer, the error message doesn't actually indicate this. Instead, it reports an "actual type" of '' - the empty string. This is a known limitation of the way reflect works, and is used elsewhere in the code to dereference the pointer to get the actual type. So I'm not sure why it was overlooked in this case.

Testing

A test was added to ensure this change works as expected.

Release Notes

NONE

@danhunsaker danhunsaker requested a review from a team as a code owner March 19, 2023 17:24
@danhunsaker
Copy link
Author

I'll do a v3 version of this if needed once v3 supports configuration files.

@danhunsaker
Copy link
Author

Further exploration reveals this is inaccurate. I need to figure out what type I actually get and provide a fix that way. Closing until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant