Make *cli.Context implement context.Context by renaming Value #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
given some disagreement with gofmt that seems to have shown up in 1.19
and approve word-wrapping changes to godoc
This allows users to configure the basis for integer parsing.
Co-authored-by: Dan Buch <dan@meatballhat.com>
Co-authored-by: Dan Buch <dan@meatballhat.com>
Co-authored-by: Dan Buch <dan@meatballhat.com>
Co-authored-by: Dan Buch <dan@meatballhat.com>
Co-authored-by: Dan Buch <dan@meatballhat.com>
Co-authored-by: Dan Buch <dan@meatballhat.com>
First cut at using generics for base flag types
21 tasks
skelouse
reviewed
Jan 12, 2023
| @@ -20,6 +20,9 @@ type Context struct { | |||
| parentContext *Context | |||
| } | |||
|
|
|||
| // ensures that Context always implements context.Context | |||
| var _ context.Context = &Context{} | |||
There was a problem hiding this comment.
Put this in context_test.go so that it does not effect built binary.
jalavosus
approved these changes
Jan 12, 2023
|
@marwan-at-work Can you rebase main ? |
|
The description doesn't say WHY you want cli.Context to implement context.Context. What value does this bring? |
|
This PR changes a lot of code, there are tons of merge conflicts, and v2 is effectively in maintenance mode right now. I'm leaning toward closing this PR, but would like to hear @meatballhat / @dearchap / @Juneezee opinion first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR runs the
goplsrename function on the*cli.Context.Valuemethod to be renamed toGetValue. This makes the *cli.Context implement context.Context by default as the interface is already embedded into the struct, the only reason it didn't implement it before was because of that method name conflicting in the signature.See #833 (comment)