Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting changes from main to v3-dev-main (circa 2022-10-09) #1525

Merged
merged 25 commits into from Oct 16, 2022
Merged

Porting changes from main to v3-dev-main (circa 2022-10-09) #1525

merged 25 commits into from Oct 16, 2022

Commits on Oct 9, 2022

  1. wrap: Avoid trailing whitespace for empty lines

    @abitrolly @meatballhat
    abitrolly authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    a6f5ca6 View commit details
    Browse the repository at this point in the history

  2. Fix test for removed trailing whitespace

    @abitrolly @meatballhat
    abitrolly authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    d3bb381 View commit details
    Browse the repository at this point in the history

  3. wrap: Simplify loop logic 

    Suggested by @julian7
    @abitrolly @meatballhat
    abitrolly authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    05fb755 View commit details
    Browse the repository at this point in the history

  4. Run go fmt

    @abitrolly @meatballhat
    abitrolly authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    e14dca7 View commit details
    Browse the repository at this point in the history

  5. Refactor wrap() and add test for empty line

    @abitrolly @meatballhat
    abitrolly authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    4959a9f View commit details
    Browse the repository at this point in the history

  6. Call FlagStringer in String() method of slice flags 

    The default help template relies on the String() method of Flag
to render the flag. For most flag types, String() indirects through
FlagStringer, so that is the best place to customize flag rendering.

FlagStringer was not called for slice flags because their help output
differs from other flags in two ways: there can be multiple default
values, and the flag name is shown two times to indicate that the flag
can be specified multiple times.

To make multiple values work in the FlagStringer, I simply changed
GetValue() to return all values.

Showing the flag more than once is achieved through a new interface,
DocGenerationSliceFlag, which the FlagStringer uses to decide whether
the flag is a slice flag type.
    @fjl @meatballhat
    fjl authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    82ea9f7 View commit details
    Browse the repository at this point in the history

  7. Ensure "generate" step runs in CI prior to diff check

    @meatballhat
    meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    65c98c8 View commit details
    Browse the repository at this point in the history

  8. Only run generate on go 1.19

    @meatballhat
    meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    c5057d1 View commit details
    Browse the repository at this point in the history

  9. Set destination in GenericFlag apply function 

    The function was missing destination configuration.
    @nkuba @meatballhat
    nkuba authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    01bdec7 View commit details
    Browse the repository at this point in the history

  10. Add unit test for GenericFlag Destination parsing 

    The test checks if Destination provided in GenericFlag is being set as
expected.
    @nkuba @meatballhat
    nkuba authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    b82e628 View commit details
    Browse the repository at this point in the history

  11. Fix:(issue_1505) Fix flag alignment in help

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    13860a7 View commit details
    Browse the repository at this point in the history

  12. Fix command help subcommand

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    ae8c511 View commit details
    Browse the repository at this point in the history

  13. Add test case

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    c86805d View commit details
    Browse the repository at this point in the history

  14. Componentize template

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    dccd762 View commit details
    Browse the repository at this point in the history

  15. Update template.go 

    Co-authored-by: Anatoli Babenia <anatoli@rainforce.org>
    @dearchap @abitrolly @meatballhat
    2 people authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    a4b7759 View commit details
    Browse the repository at this point in the history

  16. Add test coverage for Command.VisibleCommands()

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    9a94619 View commit details
    Browse the repository at this point in the history

  17. Remove extra 3 spaces in last line

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    ea28930 View commit details
    Browse the repository at this point in the history

  18. Fix:(issue_1500). Fix slice flag value duplication issue

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    924ebda View commit details
    Browse the repository at this point in the history

  19. Fix failed test

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    fcb0bce View commit details
    Browse the repository at this point in the history

  20. Merge remote-tracking branch 'origin/v3-dev-main' into v3-porting

    @meatballhat
    meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    64facdb View commit details
    Browse the repository at this point in the history

  21. Remove duplicate DocGenerationFlag interface 

    introduced via merge
    @meatballhat
    meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    9621675 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Backfill drop of generated GetDefaultText method

    @meatballhat
    meatballhat committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    6404f1d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Build and run urfave-cli-genflags via its Makefile 

    so that `go.mod` files don't get all confused
    @meatballhat
    meatballhat committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    b458207 View commit details
    Browse the repository at this point in the history

  2. Use existing goimports installation if available

    @meatballhat
    meatballhat committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    75aabac View commit details
    Browse the repository at this point in the history

  3. Un-regress from v3 porting losses

    @meatballhat
    meatballhat committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    85ff0c5 View commit details
    Browse the repository at this point in the history