Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting to v3 #1510

Merged
merged 98 commits into from Oct 6, 2022
Merged

Porting to v3 #1510

merged 98 commits into from Oct 6, 2022

Commits on Oct 1, 2022

  1. Fix for TimestampFlag.GetValue to return empty string without value

    @hmiyado @meatballhat
    hmiyado authored and meatballhat committed Oct 1, 2022
    Copy the full SHA
    dd9cd61 View commit details
    Browse the repository at this point in the history

  2. Fix HideHelp

    @meatballhat
    Dokiy authored and meatballhat committed Oct 1, 2022
    Copy the full SHA
    67f592a View commit details
    Browse the repository at this point in the history

  3. Fix After not run

    @meatballhat
    Dokiy authored and meatballhat committed Oct 1, 2022
    Copy the full SHA
    02eb392 View commit details
    Browse the repository at this point in the history

  4. issue_62: Make slice options more posix like

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 1, 2022
    Copy the full SHA
    bc99b58 View commit details
    Browse the repository at this point in the history

  5. Changes from code review

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 1, 2022
    Copy the full SHA
    45a1375 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. Move genflags tool to cmd/ and pin to previous release 

    to alleviate problems caused by the circular dependency of using the
same code as a library that is potentially being generated to adhere to
a different API.
    @meatballhat
    meatballhat committed Oct 2, 2022
    Copy the full SHA
    2ca9143 View commit details
    Browse the repository at this point in the history

  2. Tidy up top-level go.mod

    @meatballhat
    meatballhat committed Oct 2, 2022
    Copy the full SHA
    d8de3b5 View commit details
    Browse the repository at this point in the history

  3. Add missing go.sum entries for go 1.16.x

    @meatballhat
    meatballhat committed Oct 2, 2022
    Copy the full SHA
    a5313eb View commit details
    Browse the repository at this point in the history

  4. Use goimports as formatting standard 

    given some disagreement with gofmt that seems to have shown up in 1.19
    @meatballhat
    meatballhat committed Oct 2, 2022
    Copy the full SHA
    cbc7f1a View commit details
    Browse the repository at this point in the history

  5. Shift supported go versions 

    and approve word-wrapping changes to godoc
    @meatballhat
    meatballhat committed Oct 2, 2022
    Copy the full SHA
    76bb9f1 View commit details
    Browse the repository at this point in the history

  6. split v1 docs into individual pages

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    1ae70fc View commit details
    Browse the repository at this point in the history

  7. breakup v2 documentation

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    edaf885 View commit details
    Browse the repository at this point in the history

  8. update sidebar configuration

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    18f8e6d View commit details
    Browse the repository at this point in the history

  9. add tags plugin

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    7cfafe8 View commit details
    Browse the repository at this point in the history

  10. add tags and boost for pages

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    8036eac View commit details
    Browse the repository at this point in the history

  11. wip: add --walk flag to gfrun to accept directory

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    d217a5a View commit details
    Browse the repository at this point in the history

  12. pass in correct root

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    87f003f View commit details
    Browse the repository at this point in the history

  13. rename filename to dirPath

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    2b1a8ca View commit details
    Browse the repository at this point in the history

  14. Fix:(issue_1094) Dont execute Before/After handlers during shell comp… 

    …letion
    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    42d8058 View commit details
    Browse the repository at this point in the history

  15. Rename function

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    42eb492 View commit details
    Browse the repository at this point in the history

  16. Fix:(issue_1455) Allow bool flags from input altsrc

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    78dac9c View commit details
    Browse the repository at this point in the history

  17. Remove debug println

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    3c6588c View commit details
    Browse the repository at this point in the history

  18. Revert godoc changes

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    f515798 View commit details
    Browse the repository at this point in the history

  19. Add configurable Base to int, uint and uint64 flags 

    This allows users to configure the basis for integer parsing.
    @ccremer @meatballhat
    ccremer authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    382386a View commit details
    Browse the repository at this point in the history

  20. fix: allow required flag with one character

    @Gerrard-YNWA @meatballhat
    Gerrard-YNWA authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    9de6fa4 View commit details
    Browse the repository at this point in the history

  21. fix: update test case

    @Gerrard-YNWA @meatballhat
    Gerrard-YNWA authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    9092325 View commit details
    Browse the repository at this point in the history

  22. adding in boolean alias support

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    e0db267 View commit details
    Browse the repository at this point in the history

  23. adding string alias and test

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    50bbb4a View commit details
    Browse the repository at this point in the history

  24. adding int alias and test

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    5a5789a View commit details
    Browse the repository at this point in the history

  25. add support for duration flag

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    c512a28 View commit details
    Browse the repository at this point in the history

  26. adding float flag alias support

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    126d238 View commit details
    Browse the repository at this point in the history

  27. adding alias support to remaining flags and fixing tests

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    9630e10 View commit details
    Browse the repository at this point in the history

  28. fixing test

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    9a33ae8 View commit details
    Browse the repository at this point in the history

  29. Modify nesting flag apply

    @meatballhat
    Dokiy authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    d520bfc View commit details
    Browse the repository at this point in the history

  30. Update v2 dead link

    @abousselmi @meatballhat
    abousselmi authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    445734d View commit details
    Browse the repository at this point in the history

  31. Fix:(issue_1293) Wrap usage text for commands

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    b539ee7 View commit details
    Browse the repository at this point in the history

  32. Change way to calculate offset

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    d89bc4a View commit details
    Browse the repository at this point in the history

  33. Make test case more robust

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    96e41a6 View commit details
    Browse the repository at this point in the history

  34. Remove add function

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    e48d377 View commit details
    Browse the repository at this point in the history

  35. Add comment

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    321d493 View commit details
    Browse the repository at this point in the history

  36. Add App.UnknownFlagHandler

    @icholy @meatballhat
    icholy authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    6331815 View commit details
    Browse the repository at this point in the history

  37. Rename App.UnknownFlagHandler to App.InvalidFlagAccessHandler

    @icholy @meatballhat
    icholy authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    e19a34c View commit details
    Browse the repository at this point in the history

  38. Traverse parent contexts

    @icholy @meatballhat
    icholy authored and meatballhat committed Oct 2, 2022
    Copy the full SHA
    4bce542 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Fix:(issue_1272) Generic flag not set from env

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    68cd3e8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/v3-dev-main' into v3-porting

    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    d34a232 View commit details
    Browse the repository at this point in the history

  3. Use cli/v2 in genflags tool (for now?)

    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    1446649 View commit details
    Browse the repository at this point in the history

  4. Update cli.yml 

    Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>
    @sashashura @meatballhat
    sashashura authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    e57f53b View commit details
    Browse the repository at this point in the history

  5. Update version of codecov action 

    given errors seen in other PRs using v2
    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    8609031 View commit details
    Browse the repository at this point in the history

  6. Explicitly pass CODECOV_TOKEN

    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    31edfd6 View commit details
    Browse the repository at this point in the history

  7. Add a few notes to release docs 

    about the relationship to proxy.golang.org and automatically generated
release notes.
    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    eea567a View commit details
    Browse the repository at this point in the history

  8. Add count option for bool flags

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    03487fc View commit details
    Browse the repository at this point in the history

  9. Merge changes onto latest main

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    2941bc8 View commit details
    Browse the repository at this point in the history

  10. Remove go changes

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    c4251de View commit details
    Browse the repository at this point in the history

  11. Update for build

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    2b0db3b View commit details
    Browse the repository at this point in the history

  12. Merge main and run tidy

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    c0a2866 View commit details
    Browse the repository at this point in the history

  13. Rebase main

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    2f082d6 View commit details
    Browse the repository at this point in the history

  14. Add to docs

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    2f66431 View commit details
    Browse the repository at this point in the history

  15. Update docs

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    b694a25 View commit details
    Browse the repository at this point in the history

  16. Update godocs

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    cbd62ef View commit details
    Browse the repository at this point in the history

  17. Add args

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    3adf8fa View commit details
    Browse the repository at this point in the history

  18. Update docs/v2/examples/flags.md 

    Co-authored-by: Dan Buch <dan@meatballhat.com>
    @dearchap @meatballhat
    dearchap and meatballhat committed Oct 3, 2022
    Copy the full SHA
    fa3bbf9 View commit details
    Browse the repository at this point in the history

  19. Add context.Count

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    c0a8506 View commit details
    Browse the repository at this point in the history

  20. Add parametrize tests

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    6b0a3e8 View commit details
    Browse the repository at this point in the history

  21. Add countable interface

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    a509290 View commit details
    Browse the repository at this point in the history

  22. Remove keystroke errors

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    d58b3c7 View commit details
    Browse the repository at this point in the history

  23. Merge changes from main

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    fdcbf28 View commit details
    Browse the repository at this point in the history

  24. Rebase

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    0764ca2 View commit details
    Browse the repository at this point in the history

  25. Fix tests per latest main

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    7097d0e View commit details
    Browse the repository at this point in the history

  26. Fix formatting

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    7405a90 View commit details
    Browse the repository at this point in the history

  27. Merge from main

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    9bcffd0 View commit details
    Browse the repository at this point in the history

  28. Add coverage threshold

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    2a5960c View commit details
    Browse the repository at this point in the history

  29. Add additional test to fix codecov

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    5b96605 View commit details
    Browse the repository at this point in the history

  30. Add additional test to fix codecov

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    9c5b385 View commit details
    Browse the repository at this point in the history

  31. Set codecov status thresholds to 5% 

    and rename file to be less dotty
    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    0658d61 View commit details
    Browse the repository at this point in the history

  32. Fix: dont generate pointer for dest for Generic flag

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    e13c16b View commit details
    Browse the repository at this point in the history

  33. Fix: Help name consistency among app/commands and subcommands

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    8e3fa06 View commit details
    Browse the repository at this point in the history

  34. Move more functionality into internal/build/build.go 

    and use make targets in CI, pass flag spec YAML through yq

includes result of running `make v2approve`
    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    8cc0a9c View commit details
    Browse the repository at this point in the history

  35. Run make target after the Makefile is available

    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    d9d960a View commit details
    Browse the repository at this point in the history

  36. Use windows compatible path append

    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    2bec081 View commit details
    Browse the repository at this point in the history

  37. Only run make v2diff on go 1.19.x + ubuntu-latest

    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    0593812 View commit details
    Browse the repository at this point in the history

  38. Replace a few more custom make targets

    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    d6c9f6a View commit details
    Browse the repository at this point in the history

  39. Use correct env var for global flags

    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    9ed5a09 View commit details
    Browse the repository at this point in the history

  40. Accept the MKDOCS_REMOTE_GITHUB_TOKEN var as intended

    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    1c3ebfa View commit details
    Browse the repository at this point in the history

  41. Fix:(issue_1197) Set destination field from altsrc for slice flags

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    d2acd0e View commit details
    Browse the repository at this point in the history

  42. Add unit tests

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    e9e87f6 View commit details
    Browse the repository at this point in the history

  43. fix: Context.Set no such flag

    @meatballhat
    torwang authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    a2c3729 View commit details
    Browse the repository at this point in the history

  44. feat: flag action

    @xwjdsh @meatballhat
    xwjdsh authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    e2e14ec View commit details
    Browse the repository at this point in the history

  45. Add more tests about flag-level action

    @xwjdsh @meatballhat
    xwjdsh authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    f9ceca5 View commit details
    Browse the repository at this point in the history

  46. Rebase main, update flag-spec.yaml to add Action field

    @xwjdsh @meatballhat
    xwjdsh authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    d213683 View commit details
    Browse the repository at this point in the history

  47. make v2approve

    @xwjdsh @meatballhat
    xwjdsh authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    1e30f50 View commit details
    Browse the repository at this point in the history

  48. Add more test cases

    @xwjdsh @meatballhat
    xwjdsh authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    126297a View commit details
    Browse the repository at this point in the history

  49. Fix:(issue_557) Change app help name

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    4c637d8 View commit details
    Browse the repository at this point in the history

  50. Fix:(issue_557) Make help output consistent between different invocat… 

    …ions
    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    57ff098 View commit details
    Browse the repository at this point in the history

  51. Remove un-needed func

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    c2ecb44 View commit details
    Browse the repository at this point in the history

  52. Remove un-needed func

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Copy the full SHA
    8ef92d2 View commit details
    Browse the repository at this point in the history

  53. Remove nonexistent phony targets 

    so that running `make` or `make all` only runs targets that exist.
    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    5db9db6 View commit details
    Browse the repository at this point in the history

  54. Post-porting fixes for v3

    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    f8faf77 View commit details
    Browse the repository at this point in the history

  55. Point docs tests at v3

    @meatballhat
    meatballhat committed Oct 3, 2022
    Copy the full SHA
    a851a77 View commit details
    Browse the repository at this point in the history