Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure GenericFlag's Destination type as struct not pointer #1442

Merged
merged 6 commits into from Oct 6, 2022

Commits on Oct 6, 2022

  1. Add DestinationPointer for flags generator

    In this commit I added a DestinationPointer variable that should be set
    if the `Destination` should be configured as a pointer for a specific
    flag type. It is expected that Generic type which is an interface will
    not be a pointer but a struct. Before this change the code compilation
    was failing with `type *Generic is pointer to interface, not interface`.
    
    See urfave#1441
    nkuba authored and dearchap committed Oct 6, 2022
    Copy the full SHA
    891ffb0 View commit details
    Browse the repository at this point in the history
  2. Set destination in GenericFlag apply function

    The function was missing destination configuration.
    nkuba authored and dearchap committed Oct 6, 2022
    Copy the full SHA
    a2541e0 View commit details
    Browse the repository at this point in the history
  3. Add unit test for GenericFlag Destination parsing

    The test checks if Destination provided in GenericFlag is being set as
    expected.
    nkuba authored and dearchap committed Oct 6, 2022
    Copy the full SHA
    c472192 View commit details
    Browse the repository at this point in the history
  4. After rebase

    dearchap committed Oct 6, 2022
    Copy the full SHA
    d724a63 View commit details
    Browse the repository at this point in the history
  5. Fix compile

    dearchap committed Oct 6, 2022
    Copy the full SHA
    a9c758e View commit details
    Browse the repository at this point in the history
  6. Revert main_test

    dearchap committed Oct 6, 2022
    Copy the full SHA
    67f293a View commit details
    Browse the repository at this point in the history