Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging main to v3 dev main #1437

Merged
merged 199 commits into from Jul 16, 2022
Merged

Conversation

meatballhat
Copy link
Member

@meatballhat meatballhat commented Jul 16, 2022

What type of PR is this?

  • maintenance

What this PR does / why we need it:

Get v3-dev-main up to date with main

Which issue(s) this PR fixes:

N/A 😬

(what I meant to do in #1435)

(shame on me for attempting to Do Things before Being Awake)

michaeljs1990 and others added 30 commits January 27, 2019 01:41
This adds what I think needs to be done to support categories for flags
but we will see if that works. It also forces the scripts to use python2
since they blow up under python3 which is becoming the default python on
many linux systems.

Small fix to app_test as well so it conforms to the new Flag interface.
Let us use this repo via replace locally.
The new option `app.Suggest` enables command and flag suggestions via
the jaro-winkler distance algorithm. Flags are scoped to their
appropriate commands whereas command suggestions are scoped to the
current command level.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
If you allow a flag to be set from environment variables or files and
a parse error occurs from one of them, it is very useful for the error
message to mention where the value came from.

Without this, it can be difficult to notice an error caused by an
unexpected environment variable being set.

Implements #1167.
move bool to the end of the return arguments

remove "from " prefix in the source/fromWhere description

remove TODO notes from functions that don't currently perform error checking
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Completion file shouldn't be sourced. It should provide only completion
code (source of _command) for command. It's task for package manager or
user to put under $fpath.
There is no need to define custom shell var, when Zsh can be detected by
checking SHELL env var.
…ynb/cli into mostynb-report_source_of_parse_errors
Update dependencies and go.mod spec
show only subcommand flags with bash completion (#1186)
Remove reflect calls for doc generation (#1259)
so that it does not panic when run.
jszwedko and others added 25 commits June 18, 2022 13:38
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Update dependencies to latest
Remove temporary go mod workaround
includes:
- running each example through `goimports`
- wrapping text at ~80 cols
- consistently using `&cli.App{...}`
- consistently using code example gates
- removing trailing blankspace
subcommand names of a default command (should it be set)
Fix list formatting in v2 manual
feature: add DefaultCommand field to App
Approve v2 addition of App.DefaultCommand

@jalavosus FYI I'm merging this now with the intent to tag and push `v2.11.0`, and I'm happy to see further documentation improvements released later.
@meatballhat meatballhat requested a review from a team as a code owner July 16, 2022 12:00
@meatballhat meatballhat merged commit cb7532a into v3-dev-main Jul 16, 2022
@meatballhat meatballhat deleted the merging-main-to-v3-dev-main branch July 16, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet