Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SliceFlag wrapper and fix bugs in existing implementations #1409

Merged
merged 2 commits into from Jun 18, 2022
Merged

Add SliceFlag wrapper and fix bugs in existing implementations #1409

merged 2 commits into from Jun 18, 2022

Commits on Jun 6, 2022

  1. Add SliceFlag wrapper and fix bugs in existing implementations 

    The SliceFlag implementation and associated aliases (MultiStringFlag, etc)
extend the existing slice implementations (StringSliceFlag, etc) to support
actual slices as the flag value and destination.

This change also fixes various bugs in the existing implementation. Notably,
the StringSliceFlag.Apply implementation would modify the input (default)
Value, if an env var was set, and no destination was provided. The bugs fixed
in the other three implementations were all already fixed in either
StringSliceFlag, or in one case (ignoring empty env var) in Float64SliceFlag.
    @joeycumines
    joeycumines committed Jun 6, 2022
    Copy the full SHA
    e77dd7b View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2022

  1. Fix build for go < 1.18

    @joeycumines
    joeycumines committed Jun 12, 2022
    Copy the full SHA
    4f795e3 View commit details
    Browse the repository at this point in the history