Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1] do fix CI #1384

Merged
merged 2 commits into from May 4, 2022
Merged

[v1] do fix CI #1384

merged 2 commits into from May 4, 2022

Commits on May 3, 2022

  1. Really fix TestApp_RunAsSubCommandIncorrectUsage 

    An earlier commit 6564c0f made an attempt at fixing this test,
but apparently it is not working correctly with Go <= 1.16, because
the panic is expected, and it only happens with Go 1.17+.

Rather than adding an ugly kludge checking the runtime go version,
let's have two versions of the test.

Once Go 1.16 is no longer supported, we can remove the go116_test.go
file.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed May 3, 2022
    Copy the full SHA
    b370d04 View commit details
    Browse the repository at this point in the history

  2. Fix CI 

    Due to an issue with commit 6564c0f, only the first line was
executed, so the tests were not executed on GHA CI.

Fixes: 6564c0f
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed May 3, 2022
    Copy the full SHA
    22281d3 View commit details
    Browse the repository at this point in the history