Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature:(Issue 1334) Add support for uint64slices #1378

Merged
merged 8 commits into from Sep 10, 2022
Merged

Feature:(Issue 1334) Add support for uint64slices #1378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f8b9a7c
Merge changes from main
dearchap Aug 13, 2022
f11dfa6
Rebase
dearchap Aug 15, 2022
ec257a8
Fix tests per latest main
dearchap Aug 15, 2022
0c7dcf7
Fix formatting
dearchap Aug 31, 2022
f6b4ee0
Merge from main
dearchap Aug 31, 2022
4f9b8e4
Add coverage threshold
dearchap Sep 6, 2022
b087856
Add additional test to fix codecov
dearchap Sep 10, 2022
d0fff2e
Add additional test to fix codecov
dearchap Sep 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/.codecov.yml
View file
Open in desktop
@@ -1 +1,3 @@
comment: false
coverage:
threshold: 5%
2 changes: 1 addition & 1 deletion altsrc/flag_test.go
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@ func (ris *racyInputSource) isSet(name string) bool {
func TestGenericApplyInputSourceValue_Alias(t *testing.T) {
v := &Parser{"abc", "def"}
tis := testApplyInputSource{
Flag: NewGenericFlag(&cli.GenericFlag{Name: "test", Aliases: []string{"test_alias"}, Value: &Parser{}}),
Flag: NewGenericFlag(&cli.GenericFlag{Name: "test", Aliases: []string{"test_alias"}, Value: &Parser{}}),
FlagName: "test_alias",
MapValue: v,
}
Expand Down
13 changes: 9 additions & 4 deletions flag-spec.yaml
View file
Open in desktop
Expand Up @@ -55,7 +55,12 @@ flag_types:
- { name: Layout, type: string }
- { name: Timezone, type: "*time.Location" }

# TODO: enable UintSlice
# UintSlice: {}
# TODO: enable Uint64Slice once #1334 lands
# Uint64Slice: {}
UintSlice:
value_pointer: true
skip_interfaces:
- fmt.Stringer
Uint64Slice:
value_pointer: true
skip_interfaces:
- fmt.Stringer