Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not apply altsrc input values that are not set #1376

Merged
merged 6 commits into from Apr 26, 2022
Merged

Do not apply altsrc input values that are not set #1376

merged 6 commits into from Apr 26, 2022

Commits on Apr 26, 2022

  1. Add failing test for #1373

    @meatballhat
    meatballhat committed Apr 26, 2022
    Copy the full SHA
    e3aa8d3 View commit details
    Browse the repository at this point in the history

  2. Only apply altsrc input source values when set 

    Closes #1373
    @meatballhat
    meatballhat committed Apr 26, 2022
    Copy the full SHA
    efe0449 View commit details
    Browse the repository at this point in the history

  3. Make the altsrc input source context isSet method private 

    so that it doesn't extend the public surface area, instead focusing on
being a bugfix _only_.
    @meatballhat
    meatballhat committed Apr 26, 2022
    Copy the full SHA
    fe1468c View commit details
    Browse the repository at this point in the history

  4. Add more test coverage around unset input source applying

    @meatballhat
    meatballhat committed Apr 26, 2022
    Copy the full SHA
    ac641ff View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into duration-default-regression

    @meatballhat
    meatballhat committed Apr 26, 2022
    Copy the full SHA
    8fe4d79 View commit details
    Browse the repository at this point in the history

  6. Drop extra if condition

    @meatballhat
    meatballhat committed Apr 26, 2022
    Copy the full SHA
    cdb1730 View commit details
    Browse the repository at this point in the history