Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add urfave_cli_no_docs build tag #1375

Merged
merged 4 commits into from Apr 26, 2022
Merged

Add urfave_cli_no_docs build tag #1375

merged 4 commits into from Apr 26, 2022

Commits on Apr 25, 2022

  1. Move some test helpers from docs_test to fish_test 

    This is in preparation to make docs optional.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Apr 25, 2022
    Copy the full SHA
    aabfea8 View commit details
    Browse the repository at this point in the history

  2. Add urfave_cli_no_docs build tag 

    This removes the resulting binary dependency on cpuguy83/md2man and
russross/blackfriday, which saves more than 400 KB (more than 300 KB
once stripped) from the resulting binary.

Document this in README.
    @kolyshkin
    kolyshkin committed Apr 25, 2022
    Copy the full SHA
    49e43be View commit details
    Browse the repository at this point in the history

  3. ci: test newly added tag 

    We run test with the tag set (to make sure nothing is broken),
and also the check-binary-size target (for informational purposes only).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Apr 25, 2022
    Copy the full SHA
    b8cb475 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Merge branch 'main' into no-docs

    @meatballhat
    meatballhat committed Apr 26, 2022
    Copy the full SHA
    e20d3d4 View commit details
    Browse the repository at this point in the history