Make ToMarkdown and ToMan optional
#1363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality is not always used, and it brings in quite a big dependency (russross/blackfriday). Amend the documentation to make it clear that cli_docs build tag is needed to use these functions. This reduces runc size by about 318 Kb, or 3.4% (comparing stripped binaries). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
meatballhat
added
area/v1
kolyshkin
force-pushed
the
v1-docs-optional
branch
from
df47bb0
to
2181262
Compare
meatballhat
changed the title
ToMarkdown and ToMan optionalToMarkdown and ToMan optional
|
@kolyshkin What do you think about inverting the build constraint so that the default behavior remains the same? Is opting out of the docs bits something that can be introduced in |
|
Yes, that's possible, too. I will redo. |
|
Opened #1375 as a replacement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Their functionality is not always used, and it brings in quite a big
dependency (russross/blackfriday).
Amend the documentation to make it clear that cli_docs build tag is
needed to use these functions.
This reduces runc size by about 318 Kb, or 3.4% (comparing stripped
binaries).
Which issue(s) this PR fixes:
none
Special notes for your reviewer:
none
Testing
Release Notes