Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging mostynb report source of parse errors #1354

Merged
merged 6 commits into from May 22, 2022
Merged

Merging mostynb report source of parse errors #1354

merged 6 commits into from May 22, 2022

Commits on Nov 3, 2020

  1. Report the source of a value when we cannot parse it 

    If you allow a flag to be set from environment variables or files and
a parse error occurs from one of them, it is very useful for the error
message to mention where the value came from.

Without this, it can be difficult to notice an error caused by an
unexpected environment variable being set.

Implements #1167.
    @mostynb
    mostynb committed Nov 3, 2020
    Copy the full SHA
    500d6b0 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2020

  1. fixup! Report the source of a value when we cannot parse it 

    move bool to the end of the return arguments

remove "from " prefix in the source/fromWhere description

remove TODO notes from functions that don't currently perform error checking
    @mostynb
    mostynb committed Nov 7, 2020
    Copy the full SHA
    cdc1f6e View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Merge branch 'report_source_of_parse_errors' of ssh://github.com/most… 

    …ynb/cli into mostynb-report_source_of_parse_errors
    @meatballhat
    meatballhat committed Apr 19, 2022
    Copy the full SHA
    826b3ed View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2022

  1. Merge remote-tracking branch 'origin/main' into mostynb-report_source… 

    …_of_parse_errors
    @meatballhat
    meatballhat committed Apr 30, 2022
    Copy the full SHA
    e7db6af View commit details
    Browse the repository at this point in the history

Commits on May 7, 2022

  1. Merge branch 'main' into mostynb-report_source_of_parse_errors

    @meatballhat
    meatballhat committed May 7, 2022
    Copy the full SHA
    04f5ff0 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2022

  1. Merge remote-tracking branch 'origin/main' into mostynb-report_source… 

    …_of_parse_errors
    @meatballhat
    meatballhat committed May 22, 2022
    Copy the full SHA
    fc27cb0 View commit details
    Browse the repository at this point in the history