Added script to generate altsrc flag definitions #1244
Conversation
ipostelnik
requested review from
coilysiren and
asahasrabuddhe
and removed request for
a team
…t sources. - Updated unit tests for atlsrc handling to match expected usage via cli.App. Previously, the tests tried to mock cli.Context which caused differences in behavior. - The types of altsrc flags are now limited to the subset that provide FlagInputSourceExtension implementation and have matching methods in InputSourceContext interface. Removed types where never updated from the input source. - Added script to generate altsrc flag definitions, restricted list of types to the ones that provide implementation of FlagInputSourceExtension. The original program to generate altsrc flags is nowhere to be found, so replaced with fg.py.
ipostelnik
force-pushed
the
igor/altsrc-consistency
branch
from
dc5f4fc
to
d3bb346
Compare
coilysiren
requested review from
a team
and removed request for
coilysiren and
asahasrabuddhe
|
This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else. |
|
Closing this as it has become stale. |
meatballhat
added
area/v2
meatballhat
changed the title
meatballhat
added
kind/bug
|
@ipostelnik Sorry for the long delay! 😭 Any chance you're interested in refreshing this work, especially in light of the most recent round of flag generation tooling? |
|
@dearchap if you're interested in seeing this work moved forward, I think I would prefer the use of the more recently-(re)introduced |
|
@meatballhat That should be fine. @ipostelnik Are you up to resolve the conflicts ? |
dearchap
added
the
status/waiting-for-response
|
PR #1553 Does this on latest and uses the internal gen flag program. |
Added script to generate altsrc flag definitions, restricted list of types to the ones that provide implementation of FlagInputSourceExtension.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Testing
Existing unit tests
Release Notes
Removed
altsrcflag definitions for types that do not implement FlagInputSourceExtension. These types did not have their values loaded from the configuration file.