fix #1239: slice flag value don't append to default values from ENV or file #1240
Conversation
vipally
requested review from
saschagrunert and
asahasrabuddhe
and removed request for
a team
There was a problem hiding this comment.
LGTM, for other people's context the pattern here is from #1078
| @@ -129,6 +129,9 @@ func (f *Float64SliceFlag) Apply(set *flag.FlagSet) error { | |||
| } | |||
| } | |||
|
|
|||
| // Set this to false so that we reset the slice if we then set values from | |||
| // flags that have already been set by the environment. | |||
| f.Value.hasBeenSet = false | |||
There was a problem hiding this comment.
Not sure if you need this. Did you try running the additional tests with s.hasBeenSet = true , they run just fine.
There was a problem hiding this comment.
I'm also not sure, but since this matches what we have for the other flags, I think it's a reasonable change to bring in.
|
This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else. |
|
This issue or PR has been bumped and is no longer marked as stale! Feel free to bump it again in the future, if it's still relevant. |
1 similar comment
|
This issue or PR has been bumped and is no longer marked as stale! Feel free to bump it again in the future, if it's still relevant. |
…r file
What type of PR is this?
What this PR does / why we need it:
fix v2 bug: slice flag value don't append to default values from ENV or file
Which issue(s) this PR fixes:
Fixes #1239
Special notes for your reviewer:
StringSliceFlag have been fixed this bug,
but Float64SliceFlag, Int64SliceFlag, IntSliceFlag have the same bug.
Testing
TestFlagsFromEnv has cover this case
Release Notes