Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Context.Value. #1210

Merged
merged 2 commits into from Jan 29, 2021
Merged

Fix Context.Value. #1210

merged 2 commits into from Jan 29, 2021

Commits on Jan 28, 2021

  1. Fix Context.Value. 

    Before this change the added test would crash on a nil
pointer dereference because the original code would
only look in the local fileSet and not across all
the fileSets.
    @jcgregorio
    jcgregorio committed Jan 28, 2021
    Copy the full SHA
    b8debb6 View commit details
    Browse the repository at this point in the history

  2. Add test for the else path.

    @jcgregorio
    jcgregorio committed Jan 28, 2021
    Copy the full SHA
    d56c85c View commit details
    Browse the repository at this point in the history