Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Go 1.15 #1200

Merged
merged 2 commits into from Nov 3, 2020
Merged

Add Support for Go 1.15 #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a5a092
Add Support for Go 1.15
asahasrabuddhe Oct 30, 2020
06e5709
Reduce desiredMinBinarySize
asahasrabuddhe Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/cli.yml
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
go: [1.12, 1.13, 1.14]
go: [1.13, 1.14, 1.15]
name: ${{ matrix.os }} @ Go ${{ matrix.go }}
runs-on: ${{ matrix.os }}
steps:
Expand All @@ -39,7 +39,7 @@ jobs:
ref: ${{ github.ref }}

- name: GOFMT Check
if: matrix.go == 1.14 && matrix.os == 'ubuntu-latest'
if: matrix.go == 1.15 && matrix.os == 'ubuntu-latest'
run: test -z $(gofmt -l .)

- name: vet
Expand All @@ -62,10 +62,10 @@ jobs:
name: test-docs
runs-on: ubuntu-latest
steps:
- name: Set up Go 1.14
- name: Set up Go 1.15
uses: actions/setup-go@v1
with:
go-version: 1.14
go-version: 1.15

- name: Use Node.js 12.x
uses: actions/setup-node@v1
Expand Down
2 changes: 1 addition & 1 deletion internal/build/build.go
View file
Open in desktop
Expand Up @@ -193,7 +193,7 @@ func checkBinarySizeActionFunc(c *cli.Context) (err error) {
cliBuiltFilePath = "./internal/example-cli/built-example"
helloSourceFilePath = "./internal/example-hello-world/example-hello-world.go"
helloBuiltFilePath = "./internal/example-hello-world/built-example"
desiredMinBinarySize = 2.0
desiredMinBinarySize = 1.9
desiredMaxBinarySize = 2.1
badNewsEmoji = "🚨"
goodNewsEmoji = "✨"
Expand Down