New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a v1 => v2 migration guide #1098
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1098 +/- ##
==========================================
- Coverage 73.18% 73.07% -0.12%
==========================================
Files 33 34 +1
Lines 2480 2488 +8
==========================================
+ Hits 1815 1818 +3
- Misses 559 564 +5
Partials 106 106
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a high level, can you move the migration guide into it's own file? I would like to see a file structure like this
./docs/migrate-v1-to-v2.md
./docs/v1/manual.md
./docs/v2/manual.md
I think that would be the best option for discoverability here 🙂 I'm imagining a complex far future world that looks like this
./docs/migrate-v1-to-v2.md
./docs/migrate-v1-to-v3.md
./docs/migrate-v2-to-v3.md
./docs/v1/manual.md
./docs/v2/manual.md
./docs/v3/manual.md
And when we're at that point, it will likely make much for sense for the migration guides to be in their own files.
Yes, I agree it works better as a separate file. How will people find it? Should I make a link to it in the manual? |
@lynncyrin I'm unclear how to fix the codecov/project failure. Can I get some assistance? |
There should be a link to the migration guide in:
|
I don't have any special knowledge about the codecov failure, and it's not really relevant to this PR. You can ignore it. |
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
A guide to migrating from v1 to v2 makes it easier for people to adopt the newer version; helps eliminate the long tail of people using old versions.
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #921
Special notes for your reviewer:
n/a
Testing
I viewed it in GitHub's preview mechanism.
Release Notes
(REQUIRED)
n/a