Use existing goimports installation if available

urfave · Oct 10, 2022 · e9f2ca4 · e9f2ca4
1 parent 6ec1f4b
commit e9f2ca4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/cmd/urfave-cli-genflags/Makefile b/cmd/urfave-cli-genflags/Makefile
@@ -1,6 +1,9 @@
+GOIMPORTS_BIN ?= $(shell which goimports || true)
 GOTEST_FLAGS ?= -v --coverprofile main.coverprofile --covermode count --cover github.com/urfave/cli/v2/cmd/urfave-cli-genflags
 GOBUILD_FLAGS ?= -x
 
+export GOIMPORTS_BIN
+
 .PHONY: all
 all: test build smoke-test
 

diff --git a/cmd/urfave-cli-genflags/main.go b/cmd/urfave-cli-genflags/main.go
@@ -94,8 +94,9 @@ func main() {
 				Value:   "cli.",
 			},
 			&cli.PathFlag{
-				Name:  "goimports",
-				Value: filepath.Join(top, ".local/bin/goimports"),
+				Name:    "goimports",
+				EnvVars: []string{"GOIMPORTS_BIN"},
+				Value:   filepath.Join(top, ".local/bin/goimports"),
 			},
 		},
 		Action: runGenFlags,