Replace a few more custom make targets

urfave · Sep 11, 2022 · 7d9264a · 7d9264a
1 parent 1a851c7
commit 7d9264a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 19 deletions.
diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml
@@ -30,11 +30,15 @@ jobs:
       - if: matrix.go == '1.19.x' && matrix.os == 'ubuntu-latest'
         run: make lint
       - run: make vet
-      - run: make tag-test
+      - run: make test
+        env:
+          FLAGS: -tags urfave_cli_no_docs
       - run: make test
       - run: make -C cmd/urfave-cli-genflags
       - run: make check-binary-size
-      - run: make tag-check-binary-size
+        env:
+          FLAGS: -tags urfave_cli_no_docs
+      - run: make check-binary-size
       - run: make yamlfmt
       - run: make diffcheck
       - if: matrix.go == '1.19.x' && matrix.os == 'ubuntu-latest'
@@ -59,6 +63,8 @@ jobs:
       - uses: actions/checkout@v3
       - run: make ensure-gfmrun
       - run: make gfmrun
+        env:
+          FLAGS: --walk docs/v2/
       - run: make diffcheck
   publish:
     permissions:
@@ -71,7 +77,9 @@ jobs:
       - uses: actions/checkout@v3
         with:
           fetch-depth: 0
-      - run: make ci-ensure-mkdocs
+      - run: make ensure-mkdocs
+        env:
+          FLAGS: --upgrade-pip
       - run: make set-mkdocs-remote
         env:
           MKDOCS_REMOTE_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

diff --git a/Makefile b/Makefile
@@ -17,22 +17,6 @@ all: generate vet tag-test test check-binary-size tag-check-binary-size gfmrun y
 %:
 	$(GO_RUN_BUILD) $(GFLAGS) $* $(FLAGS)
 
-.PHONY: tag-test
-tag-test:
-	$(GO_RUN_BUILD) -tags urfave_cli_no_docs test
-
-.PHONY: tag-check-binary-size
-tag-check-binary-size:
-	$(GO_RUN_BUILD) -tags urfave_cli_no_docs check-binary-size
-
-.PHONY: gfmrun
-gfmrun:
-	$(GO_RUN_BUILD) gfmrun --walk docs/v2/
-
-.PHONY: ci-ensure-mkdocs
-ci-ensure-mkdocs:
-	$(GO_RUN_BUILD) ensure-mkdocs --upgrade-pip
-
 .PHONY: docs
 docs:
 	mkdocs build