Fix test failures

urfave · Mar 23, 2021 · 239e218 · 239e218
1 parent 1abf95b
commit 239e218
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/flag_bool.go b/flag_bool.go
@@ -46,6 +46,7 @@ func (b *boolValue) Set(s string) error {
 	v, err := strconv.ParseBool(s)
 	if err != nil {
 		err = errors.New("parse error")
+		return err
 	}
 	*b.destination = v
 	*b.count = *b.count + 1
@@ -120,7 +121,8 @@ func (f *BoolFlag) Apply(set *flag.FlagSet) error {
 		if f.Destination != nil {
 			value = newBoolValue(f.Value, f.Destination, &f.Count)
 		} else {
-			value = newBoolValue(f.Value, &f.Value, &f.Count)
+			t := new(bool)
+			value = newBoolValue(f.Value, t, &f.Count)
 		}
 		set.Var(value, name, f.Usage)
 	}