Add type switch

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
urfave · Aug 26, 2019 · 0c01922 · 0c01922
1 parent 38d0ac6
commit 0c01922
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/fish.go b/fish.go
@@ -164,19 +164,21 @@ func fishAddFileFlag(
 	flag Flag,
 	completion *strings.Builder,
 ) {
-	addFileExclusionFlag := true
-	if f, ok := flag.(GenericFlag); ok && f.TakesFile {
-		addFileExclusionFlag = false
-	}
-	if f, ok := flag.(StringFlag); ok && f.TakesFile {
-		addFileExclusionFlag = false
-	}
-	if f, ok := flag.(StringSliceFlag); ok && f.TakesFile {
-		addFileExclusionFlag = false
-	}
-	if addFileExclusionFlag {
-		completion.WriteString(" -f")
+	switch f := flag.(type) {
+	case GenericFlag:
+		if f.TakesFile {
+			return
+		}
+	case StringFlag:
+		if f.TakesFile {
+			return
+		}
+	case StringSliceFlag:
+		if f.TakesFile {
+			return
+		}
 	}
+	completion.WriteString(" -f")
 }
 
 func (a *App) fishSubcommandHelper(allCommands []string) string {