feat: add support for span id and custom key for trace id and span id for otelzap #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragmaticivan
force-pushed
the
span-id-and-custom-key-support
branch
from
d507252
to
be42e44
Compare
pragmaticivan
commented
May 3, 2024
| @@ -439,7 +450,7 @@ func (s *SugaredLogger) FatalfContext(ctx context.Context, template string, args | |||
| func (s *SugaredLogger) logArgs( | |||
| ctx context.Context, lvl zapcore.Level, template string, args []interface{}, | |||
| ) { | |||
| if lvl < s.l.minLevel { | |||
| if lvl <= s.l.minLevel { | |||
There was a problem hiding this comment.
The current code for this line is causing some weird behaviors when the log level is debug
pragmaticivan
force-pushed
the
span-id-and-custom-key-support
branch
from
be42e44
to
f100fd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #109