Bug: NotFound handler was called although route exists #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sknr
force-pushed
the
bugfix/handle-missing-case
branch
2 times, most recently
from
5dcb9bd
to
a394720
Compare
sknr
force-pushed
the
bugfix/handle-missing-case
branch
from
a394720
to
5cebd18
Compare
|
Hi @vmihailenco, is this project still actively maintained? If yes, it would be nice if someone could have a look at my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 What has changed
There was a bug in the
_findRoutemethod of the filenode.go. Please see the adjusted testTestMethodNotAllowedinrouter_test.goas an example.✅ Before submitting, please be sure to check this list