Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unit test of query_test.go #974

Merged

Conversation

JunNishimura
Copy link
Contributor

@JunNishimura JunNishimura commented Apr 4, 2024

Since it is difficult to find out which file in the testdata/snapshots directory is associated with the query execution results of each test case in query_test.go, I assign a number for each test case.

The contents of the test cases themselves have not been changed.

@vmihailenco vmihailenco merged commit b005dc2 into uptrace:master Apr 7, 2024
4 checks passed
@vmihailenco
Copy link
Member

Thanks 👍

@JunNishimura JunNishimura deleted the sequential_numbering_for_unit_tests branch April 7, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants