Fix embedded field detection #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansmares
commented
Apr 2, 2024
| @@ -207,7 +207,7 @@ func (t *Table) processFields( | |||
| } | |||
|
|
|||
| subtable := newTable(t.dialect, fieldType, seen, canAddr) | |||
| for _, subfield := range subtable.Fields { | |||
| for _, subfield := range subtable.allFields { | |||
There was a problem hiding this comment.
Iterating over Fields skips the scanonly fields, so I suppose this should be allFields too.
It is also the case that on L177 we also iterate over subtable.allFields, so maybe this was some kind of copy paste error ?
adriansmares
force-pushed
the
fix/embeding
branch
from
75e0270
to
979287c
Compare
|
@adriansmares thanks for fixing this with a test 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the situation in which an
embedtag is combined with a set ofscanonlyfields.This issue seems to be caused by 9052fc4 - see the review comments below.
cc @vmihailenco